jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
182 stars 38 forks source link

Issue#1022: Fixing rule function_018. #1028

Closed jeremiah-c-leary closed 10 months ago

jeremiah-c-leary commented 10 months ago

Resolves #1022 Resolves #950

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f10aad2) 96.15% compared to head (bf12f3a) 96.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1028 +/- ## ========================================== - Coverage 96.15% 96.14% -0.02% ========================================== Files 1511 1514 +3 Lines 28408 28541 +133 ========================================== + Hits 27316 27441 +125 - Misses 1092 1100 +8 ``` | [Files](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary) | Coverage Δ | | |---|---|---| | [vsg/rules/function/rule\_018.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3J1bGVzL2Z1bmN0aW9uL3J1bGVfMDE4LnB5) | `100.00% <100.00%> (ø)` | | | [...not\_exist\_between\_tokens\_using\_value\_from\_token.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3J1bGVzL2luc2VydF90b2tlbl9uZXh0X3RvX3Rva2VuX2lmX2l0X2RvZXNfbm90X2V4aXN0X2JldHdlZW5fdG9rZW5zX3VzaW5nX3ZhbHVlX2Zyb21fdG9rZW4ucHk=) | `96.34% <100.00%> (-2.41%)` | :arrow_down: | | [vsg/rules/procedure/rule\_012.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3J1bGVzL3Byb2NlZHVyZS9ydWxlXzAxMi5weQ==) | `100.00% <100.00%> (ø)` | | | [vsg/rules/utils.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3J1bGVzL3V0aWxzLnB5) | `90.59% <100.00%> (-1.97%)` | :arrow_down: | | [vsg/vhdlFile/extract/\_\_init\_\_.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL2V4dHJhY3QvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [...g/vhdlFile/extract/get\_function\_subprogram\_body.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL2V4dHJhY3QvZ2V0X2Z1bmN0aW9uX3N1YnByb2dyYW1fYm9keS5weQ==) | `100.00% <100.00%> (ø)` | | | [.../vhdlFile/extract/get\_procedure\_subprogram\_body.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL2V4dHJhY3QvZ2V0X3Byb2NlZHVyZV9zdWJwcm9ncmFtX2JvZHkucHk=) | `100.00% <100.00%> (ø)` | | | [vsg/vhdlFile/extract/get\_subprogram\_body.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL2V4dHJhY3QvZ2V0X3N1YnByb2dyYW1fYm9keS5weQ==) | `100.00% <100.00%> (ø)` | | | [vsg/vhdlFile/vhdlFile.py](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary#diff-dnNnL3ZoZGxGaWxlL3ZoZGxGaWxlLnB5) | `92.53% <83.33%> (-0.12%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jeremiah-c-leary/vhdl-style-guide/pull/1028/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeremiah+Leary)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.