Closed JHertz5 closed 10 months ago
Good Evening @JHertz5 ,
I pushed an update to the issue-1034
branch. When you get a chance could you check it out and let me know if there are any other issues.
Thanks,
--Jeremy
Hi @jeremiah-c-leary. Thanks so much for taking a look at this. I have run your branch and it looks perfect!
Morning @JHertz5 ,
Awesome, I will merge this into master.
--Jeremy
Environment master branch
Describe the bug When presented with an aggregate assignment in which an array element is referenced by an expression that include parenthesis (e.g. a value of another array), the rule modifies those parentheis, even though they do no indicate a sub-array. This results in behaviour that is likely not desired by the user.
To Reproduce Steps to reproduce the behavior:
Create a file called
test.vhd
with the following contents:begin
data_concurrent <= ( c_enum_list(ENUM_LITERAL_1) => 1, others => 'X' );
proc_test : process (all) is
begin
end process proc_test;
end architecture rtl;
================================================================================ File: ./test.vhd
Phase 1 of 7... Reporting Total Rules Checked: 157 Total Violations: 6 Error : 6 Warning : 0 ----------------------------+------------+------------+-------------------------------------- Rule | severity | line(s) | Solution ----------------------------+------------+------------+-------------------------------------- concurrent_012 | Error | 16 | Add carriage return after open parenthesis. concurrent_012 | Error | 16 | Move closing parenthesis to the next line. variable_assignment_008 | Error | 28 | Add carriage return after open parenthesis. variable_assignment_008 | Error | 28 | Move closing parenthesis to the next line. sequential_009 | Error | 34 | Add carriage return after open parenthesis. sequential_009 | Error | 34 | Move closing parenthesis to the next line. ----------------------------+------------+------------+-------------------------------------- NOTE: Refer to online documentation at https://vhdl-style-guide.readthedocs.io/en/latest/index.html for more information.
Expected behavior I would expect the expression
c_enum_list(ENUM_LITERAL_1)
to be unaffected by these rules since these parenthesis do not create a sub-array within the array.