jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
187 stars 38 forks source link

`procedure_call_003` doesn't activate for a procedure call inside a process #1073

Closed JHertz5 closed 9 months ago

JHertz5 commented 9 months ago

Environment

$ vsg --version
VHDL Style Guide (VSG) version: 3.19.0+zip.file
Git commit SHA: Unknown.  Installed via zip file.

Describe the bug procedure_call_003 does not work on procedure calls within processes.

To Reproduce Steps to reproduce the behavior:

  1. Create a file called test.vhd with the following contents
    
    architecture rtl of test is

begin

proc_call(formal_1 => actual_1, formal_2 => actual_2, formal_3 => actual_3);

proc_label : process is begin

proc_call(formal_1 => actual_1,
          formal_2 => actual_2,
          formal_3 => actual_3);

end process proc_label;

end architecture rtl;

2. Create a file called test.yml with the following contents:
```vhdl
rule:
  procedure_call_003:
    first_open_paren: 'remove_new_line'
    last_close_paren: 'add_new_line'
    association_element: 'add_new_line'
    association_list_comma: 'remove_new_line'
  1. Run vsg -f ./test.vhd -c ./test.yml and observe the following output:
    $ vsg -f ./test.vhd -c ./test.yml 
    ================================================================================
    File:  ./test.vhd
    ================================================================================
    Phase 1 of 7... Reporting
    Total Rules Checked: 158
    Total Violations:    2
    Error   :     2
    Warning :     0
    ----------------------------+------------+------------+--------------------------------------
    Rule                      |  severity  |  line(s)   | Solution
    ----------------------------+------------+------------+--------------------------------------
    procedure_call_003        | Error      |          5 | Move parenthesis to next line.
    procedure_call_003        | Error      |          7 | Move parenthesis to next line.
    ----------------------------+------------+------------+--------------------------------------
    NOTE: Refer to online documentation at https://vhdl-style-guide.readthedocs.io/en/latest/index.html for more information.

    Note that the procedure_call within the process has not been picked up by the rule.

Expected behavior I would expect both procedure calls to be treated by the rule.

JHertz5 commented 9 months ago

I just noticed that the description specifies "concurrent procedure calls". I am changing this issue to a question - is there a rule that enforces structure for sequential procedure calls?

JHertz5 commented 9 months ago

I can't seem to change the tag from bug to question. I am closing this issue and will raise a separate question issue.