Closed JHertz5 closed 5 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.30%. Comparing base (
baf22da
) to head (33eb77b
). Report is 68 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves #1279 I started off by creating a new rule for each instance in which an aggregate may be used, but quickly the list got very long. I was creating rules in:
At this stage, I thought that this must be the wrong approach.This was in addition to modfying
token_case_in_range_bounded_by_tokens
to take a list of start-end pairs rather than separate start and end tokens, which meant I was touching even more of the code. So, I started from scratch and just added one rule to cover all of them.If you'd prefer to have separate rules for each instance where aggregates can be used, I'm happy to do so, but I think that this approach is much more robust and simple.