jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
192 stars 39 forks source link

Issue#1291: Corrected corner case in multiline alignment rule #1308

Open JHertz5 opened 3 weeks ago

JHertz5 commented 3 weeks ago

Resolves #1291. The fix is essentially

if len(lTemp) == 0:
+   if bIgnoreStartParen:
+       dExpectedIndent[iLine + 1] = lColumn[-1] + 1
+   else:
-   dExpectedIndent[iLine + 1] = lColumn[-1]
+       dExpectedIndent[iLine + 1] = lColumn[-1]

but I've made some additional changes to reduce code duplication (which I suspect is how the bug was introduced in the first place - there were three spots with identical code, and, when some change was made, only two spots were updated).

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.31%. Comparing base (baf22da) to head (491c20c). Report is 71 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1308 +/- ## ========================================== + Coverage 94.01% 94.31% +0.30% ========================================== Files 1557 1655 +98 Lines 29028 30231 +1203 Branches 3414 3485 +71 ========================================== + Hits 27291 28513 +1222 + Misses 1303 1291 -12 + Partials 434 427 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.