jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
185 stars 38 forks source link

[DISCUSSION/QUESTION]: instantiation_23 under Port Map Rules? #942

Closed sibeov closed 11 months ago

sibeov commented 1 year ago

What is your question? Is there perhaps a good reason as to why instantiation_023 is not listed under Port Map Rules?

I instinctively searched under Port Map Rules instead of the instantiation_023.

jeremiah-c-leary commented 1 year ago

Morning @sibeov,

It seems reasonable for instantiation_023 to be under the port map rules as the rule could the scoped to a single assignment.

Let me know if you would like it moved.

--Jeremy

sibeov commented 1 year ago

I would preferred that it would be moved there!

Would you like me to close this issue?

-- sibeov

jeremiah-c-leary commented 1 year ago

Mornong @sibeov,

We can use this issue.

--Jeremy

jeremiah-c-leary commented 1 year ago

Morning @sibeov ,

I pushed an update for this to the issue-942 branch. When you get a chance could you check it out and let me know what you think.

Thanks,

--Jeremy

sibeov commented 1 year ago

Will do. Thanks. Great.

jeremiah-c-leary commented 1 year ago

Evening @sibeov ,

Just wanted to ping you to see if you had a chance to check if the results are acceptable. I will plan to merge this to master in a week if I do not hear back from you.

--Jeremy

sibeov commented 1 year ago

Hi Jeremiah!

I will check it out asap.

jeremiah-c-leary commented 11 months ago

Afternoon @sibeov ,

I will merge to this to master.

--Jeremy

sibeov commented 10 months ago

Haha. Forgot to tell you that I found the changes to be perfect!