search

jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
192 stars 39 forks source link

Rule entity_019 does not respect case when fixing the code #944

Closed flyinged closed 1 year ago

flyinged commented 1 year ago

Environment Windows 10, WSL2, VSG 3.14.0+zip.file

Describe the bug When the entity name is missing in an entity declaration's "end entity" statement, VSG adds the entity name (according to rule entity_019), but the identifier is always lowercase.

To Reproduce Run vsg on a code that matches the following template

entity MY_ENTITY is
...
end entity;

The fixed code will be

entity MY_ENTITY is
...
end entity my_entity;

The expected result would be:

entity MY_ENTITY is
...
end entity MY_ENTITY;
jeremiah-c-leary commented 1 year ago

Morning @flyinged,

Do you have rule entity_012 configured as upper or lower?

--Jeremy

flyinged commented 1 year ago

Hi @jeremiah-c-leary

Thanks for the hint. Rule entity_012 was supposed to be disabled (in order to leave only the consistency checks on), but it was actually enabled. By disabling it, the behavior is as expected.

Sorry for the false alarm. My bad. A.