Closed JHertz5 closed 1 year ago
Afternoon @JHertz5 ,
I pushed an update for this issue to the issue-975
branch. When you get a chance could you validate it works on your end.
Thanks,
--Jeremy
Hi @jeremiah-c-leary. Thank you so much! I have taken a look. It is working excellently, except for the following error message when the rule is configured to remove the label:
================================================================================
File: test.vhd
================================================================================
Phase 1 of 7... Reporting
Total Rules Checked: 157
Total Violations: 1
Error : 1
Warning : 0
----------------------------+------------+------------+--------------------------------------
Rule | severity | line(s) | Solution
----------------------------+------------+------------+--------------------------------------
generate_011 | Error | 7 | Remove Add generate label
----------------------------+------------+------------+--------------------------------------
NOTE: Refer to online documentation at https://vhdl-style-guide.readthedocs.io/en/latest/index.html for more information.
The solution message says "Remove Add generate label, where I would expect it to only say "Remove generate label".
I have added a review to the pull request to suggest a fix, I hope that is ok.
@jeremiah-c-leary Thanks, the update has resolved that issue. It all looks good to me!
Sweet,
I will merge this to master.
--Jeremy
Environment v3.16.0
Describe the bug The rule
generate_011
configures an optional VHDL item, and is part of the structure::optional group. However, it does not have anaction
configuration like the other optional item rules. This means that, even thoughgenerate_011
is part of this group, it isn't affected by setting thisaction
configuration for the group.To Reproduce Steps to reproduce the behavior:
vsg -rc generate_011
action: '[add|remove]'
optionExpected behavior I expect generate_011 to have this configuration item so that it can be configured along with the rest of the group.
Screenshots None
Additional context None