search

jeremiahlzz / pe

0 stars 0 forks source link

Find does not match course keywords #6

Open jeremiahlzz opened 2 months ago

jeremiahlzz commented 2 months ago

The following command find CS2103 does not return Bernice even though its part of her course keyword.

image.png

nus-se-bot commented 2 months ago

Team's Response

image.png As we mentioned, only full words are matched and in your example as only one course can be assigned to one contact, the whole characters in course field considered as one word. So, Bernice's course is not "CS2103" but "CS2103 T" which is not matched with "CS2103" in your example.

Similar to https://github.com/nus-cs2103-AY2324S2/pe-dev-response/issues/3966 , tt would makes sense to have additional features to override that behavior though (so it would be a valid feature request).

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As show in the Team's provided screenshot, match is by given keyword. Keyword would imply words separated by spaces. This is further supported by their examples of Hans Bo matching Hans Gruber and Bo Yang.

One can therefore expect the course matching to work the same way. CS2103 T would search for courses containing CS2103 and T.

CS2103 T is allowed by their /f force function and is a valid use case, e.g. if you want to search for all courses containing S prefix (for finding CS special courses) find S would be the way.