jeremiahlzz / pe

0 stars 0 forks source link

Find command combining different fields may return unwanted results #7

Open jeremiahlzz opened 2 months ago

jeremiahlzz commented 2 months ago

If filtering for only TAs, you may get a person with TA in his name. This may result in sending information to the wrong people when using copy to copy their emails after. image.png

nus-se-bot commented 2 months ago

Team's Response

I don't think this is particularly problematic, because the contact's role is clearly written in the display.

Plus it's very unusual for someone to want to send something to all TAs, usually you'd want to send to one with a specific name. So we argue this is low severity.

That said, this would make for a valid feature request to improve the find command to only search one specified field on user's request.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Students may be TAs as well. TAs could be head TAs or TAs in charge of an assignment. In such cases, they would definitely need to send emails to all TAs of a course they are in charge of.

They would do this with the find ta CS1231S command, following with copy 1 copy 2 till all contacts filtered are copied and paste into the senders list. If there are many TAs, they may not notice a non-TA in the list filtered as they did not anticipate this issue.

If the email contains confidential information, such a screw-up would be disastrous.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Western middle names may be abbreviated to `TA`. Chinese / Vietnamese / etc. names may contain `Ta` for example, the Chinese name `Ta Ming Yun` or Vietnamese name `Ta Thu Thau`