search

jeremiahlzz / pe

0 stars 0 forks source link

Unclear add command requirements #9

Open jeremiahlzz opened 2 months ago

jeremiahlzz commented 2 months ago

According to the add command format, address is optional

image.png

However it is stated that the professor role requires the address attached

This should have been mentioned within the add and edit command as it is crucial information. It also invalidates the command formats as those arguments are no longer optional, they are mandatory. Adding professors would be a very common thing to do and hence would inconvenience many users. image.png

nus-pe-script commented 2 months ago

Team's Response

image.png It is mentioned within the edit command.

image.png Also, if user forgot to have address field for professor, the error message would show it is needed. Thus, I think it is serverity low, but still needs to be mentioned in "add" command section in UG.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I would also like to add that it is also a feature flaw. Since this is an app targeted at students, they would most likely be unaware of the professor's address (its creepy if they do, outside of extenuating circumstances). Having to always input a/none is annoying to all users, hence the medium severity.