search

jeremiahseun / africa_schools

A package that provides Tertiary Institutions in the African continent.
MIT License
9 stars 1 forks source link

Make a school an Object rather than a String #1

Open developerjamiu opened 2 years ago

developerjamiu commented 2 years ago

This is not an issue but a suggestion.

Currently, we're returning the list of schools as a text. However, we might want to add other data as part of a school in the future.

For the list => Current: Nigeria.universities = List Proposed: Nigeria.universities = List

For a school => Current: value = String Proposed: value = School (and you can access school using value.name)

Then, when we want to add other school info such as faculty lists, department lists, it'd be easy.

jeremiahseun commented 2 years ago

Hmm... A nice idea!

Thank you so much. I will work on that.

developerjamiu commented 2 years ago

Can you reopen this issue? Also can I send in a pull request to fix the issue?

jeremiahseun commented 2 years ago

It is opened already. Alright you can go ahead.