search

jeremy-compostella / org-msg

OrgMsg is a GNU/Emacs global minor mode mixing up Org mode and Message mode to compose and reply to emails in a Outlook HTML friendly style.
GNU General Public License v3.0
276 stars 57 forks source link

change function call trim-string to string-trim. return value after mm-distroy-parts. #107

Closed whudwl closed 3 years ago

whudwl commented 3 years ago

I took your changes into account. I added you signed-off to the notmuch: Support the `save-article-for-reply' callback patch.

Hi Jeremy. Sorry, i'm very unfamiliar with github stuff. Not sure I was looking at the right thing. I saw in below file that function (trim-string ...) is still used and (mm-destroy-parts) is still the last statement of org-msg-save-article-for-reply-notmuch making it return nil. https://github.com/whudwl/org-msg/blob/61168184280fac8db2cc680c7f1b34347f53cb20/org-msg.el

jeremy-compostella commented 3 years ago

This is where you should look at: https://github.com/jeremy-compostella/org-msg/blob/experimental/org-msg.el

On Thu, May 6, 2021, 6:12 PM David @.***> wrote:

I took your changes into account. I added you signed-off to the notmuch: Support the `save-article-for-reply' callback patch.

Hi Jeremy. Sorry, i'm very unfamiliar with github stuff. Not sure I was looking at the right thing. I saw in below file that function (trim-string ...) is still used and (mm-destroy-parts) is still the last statement of org-msg-save-article-for-reply-notmuch making it return nil.

https://github.com/whudwl/org-msg/blob/61168184280fac8db2cc680c7f1b34347f53cb20/org-msg.el

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jeremy-compostella/org-msg/pull/107#issuecomment-833986194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMACBDJUKR3XSQEOO5P47DTMM46TANCNFSM44H7IR7Q .

whudwl commented 3 years ago

just pulled latest commit from experimental branch. it works perfectly now. thank you so much.