search

jeremy-compostella / org-msg

OrgMsg is a GNU/Emacs global minor mode mixing up Org mode and Message mode to compose and reply to emails in a Outlook HTML friendly style.
GNU General Public License v3.0
276 stars 57 forks source link

Inline images missing from reply message #134

Open eddiegroves opened 2 years ago

eddiegroves commented 2 years ago

Howdy

Do you have any ideas why replying to a message is losing existing inline images for the message?

For example, if I view the original message in the browser, the image is exported and viewable as expected.

<div style="color:rgb(0,113,197);font-weight:bold;text-align:left;font-family:Arial;font-size:10pt;line-height:11pt">
<p style="text-decoration:none;margin-bottom:0px;margin-top:10px;line-height:11pt;font-size:10pt;font-family:Arial">
<img src="ciddYaVqJ/flower.jpeg" alt="flower.jpeg"></p>
</div>
Wrote /var/folders/zp/j694tcrx3vgdh9zcbg7jyg9m0000gn/T/ciddYaVqJ/flower.jpeg
Wrote /var/folders/zp/j694tcrx3vgdh9zcbg7jyg9m0000gn/T/mm-ZK7KDT.html

But If I preview or view a reply in the browser, the image in the original message is not exported along with the temp html file and the src is not updated.

<div style="color:rgb(0,113,197);font-weight:bold;text-align:left;font-family:Arial;font-size:10pt;line-height:11pt">
<p style="text-decoration:none;margin-bottom:0px;margin-top:10px;line-height:11pt;font-size:10pt;font-family:Arial">
<img src="cid:17bbd5914e3998ae01ba" alt="flower.jpeg"></p>
</div>
Wrote /private/var/folders/zp/j694tcrx3vgdh9zcbg7jyg9m0000gn/T/org-msg3ZTEWH.html

I am using Doom Emacs with mu4e.

jeremy-compostella commented 2 years ago

Good question. It works for me with the gnus backend. I guess it has something to do with the org-msg-save-article-for-reply-mu4e mu4e backend implementation which does not make use of gnus-article-browse-html-article like both gnus and mu4e do. Feel free to improve org-msg-save-article-for-reply-mu4e and submit a patch.