search

jeremy-compostella / org-msg

OrgMsg is a GNU/Emacs global minor mode mixing up Org mode and Message mode to compose and reply to emails in a Outlook HTML friendly style.
GNU General Public License v3.0
276 stars 56 forks source link

Image from the signature doesn't show on receivers end when I reply to email #162

Open AbeEtan opened 1 year ago

AbeEtan commented 1 year ago 
(package-install 'org-msg)
 (setq mail-user-agent 'mu4e-user-agent)
 (require 'org-msg)
 (setq org-msg-options "html-postamble:nil H:5 num:nil ^:{} toc:nil author:nil email:nil \\n:t"
    org-msg-startup "hidestars indent inlineimages"
    org-msg-greeting-fmt "\nHi%s,\n\n"
    org-msg-greeting-name-limit 3
    org-msg-default-alternatives '((new     . (text html))
                       (reply-to-html   . (text html))
                       (reply-to-text   . (text)))
    org-msg-convert-citation t
    org-msg-signature (file-string "~/onedrive/RoamNotes/mu4e signatures/orgmsgsignature.org"))
(org-msg-mode)

I also tried adding the signature as a greeting. org-msg-greeting-fmt (file-string "~/onedrive/RoamNotes/mu4e signatures/orgmsgsignature.org")

The issue of the image not showing still persists. Please advise.

gajama commented 1 year ago

Does the image show if you preview the message?

AbeEtan commented 1 year ago

Unfortunately, it doesn't. When I type "R" and reply to a message, the signature doesn't load in org-msg mode. Please advise.

gajama commented 1 year ago

If you export orgmsgsignature.org as HTML through the normal Org export commands, is the image included in the export?

AbeEtan commented 1 year ago

If you export orgmsgsignature.org as HTML through the normal Org export commands, is the image included in the export?

Yes, of course.

In addition, When I compose an email, the image shows up and everything, however, the problem happens when I reply to the email and want to send an email using org-msg, it doesn't work.

AbeEtan commented 1 year ago

At this point, I can confidently say that org-msg doesn't work when I reply to an email. It only works when I compose a new email/message.

If you allow me, can I rephrase my issue to "Org-msg not activated for mu4e-compose-reply".

This https://github.com/jeremy-compostella/org-msg/issues/153 seems to be my issue.

https://github.com/jeremy-compostella/org-msg/issues/153#issuecomment-1334172104

gajama commented 1 year ago

Well, the PR I put in to fix #157, which should fix #153 also, was merged yesterday, so you might want to try updating to the latest commit and see if it fixes your issue.

gajama commented 1 year ago

It works for my signature file. Mine is just some HTML wrapped in Org #+begin_export html end_export tags, and the images are links rather than inlined, but the HTML is included correctly.

AbeEtan commented 1 year ago

Amazing, it's working now for me. Apparently as you mentioned the recent updated fixed it. Thank you so much. You guys are the best!