Compatibilty with mu4e 1.12

jeremy-compostella / org-msg

OrgMsg is a GNU/Emacs global minor mode mixing up Org mode and Message mode to compose and reply to emails in a Outlook HTML friendly style.

GNU General Public License v3.0

276 stars 56 forks source link

Compatibilty with mu4e 1.12 #190

Open danielfleischer opened 3 months ago

danielfleischer commented 3 months ago

Collection of various patches to make org-msg compatible with mu 1.12+.
It will break compatibility with older versions as there are major changes in the mu library.

milanglacier commented 3 months ago

Hi I did some test on this branch, there is a small problem I noticed:

there is an error message when trying to send the mail:

primitive-undo: Changes to be undone are outside visible portion of buffer

However, the mail can be sent succesfully though. I have no idea what does this message mean.

danielfleischer commented 3 months ago

Try to comment the line:

(add-hook 'message-sent-hook 'undo t t)

I thought that isn't needed but some people came up with that fix. Also, are you following the latest code, not just the official 1.12 release?

martin5233 commented 2 months ago

I'm also experiencing a similar problem: After sending a mail I see the buffer with mail converted to HTML and the buffer marked as modified. The minibuffer contains a message 'Text is read-only'. The mail is successfully sent. I have tried commenting out the line (add-hook 'message-sent-hook 'undo t t) but this didn't help. It wasn't clear to me, what your suggestion to follow the latest code meant. Should I try to use mu4e master in conjunction with your PR? I have tried to debug into this, but was soon lost in unfamiliar code.

danielfleischer commented 2 months ago

Yes, you should use mu4e from master as there were many updates to the composing code after the official release. Perhaps I should have been more explicit, as the the 1.12 code changes fast.

milanglacier commented 2 months ago

Yes, you should use mu4e from master as there were many updates to the composing code after the official release. Perhaps I should have been more explicit, as the the 1.12 code changes fast.

if this is the case, perhaps we can’t merge this PR now? If this PR relies on the master branch code and has unresolved problems on official release.

Since I believe most of people will just follow the official release (probably install from their package manager) instead of building from the source?

danielfleischer commented 2 months ago

Well, there was a 1.12.4 release a couple of days ago, containing the fixes I'm talking about. So no need to compile from master, just make sure you are updating, and not use the original 1.12.0 from February.

milanglacier commented 2 months ago

Just updated my mu to 1.12.4 and it seems that it just works. No strange errors, and the mail was sent successfully.