jeremy-compostella / org-msg

OrgMsg is a GNU/Emacs global minor mode mixing up Org mode and Message mode to compose and reply to emails in a Outlook HTML friendly style.
GNU General Public License v3.0
275 stars 58 forks source link

Add customization points to enable inline-posting #84

Closed adl closed 3 years ago

adl commented 3 years ago

As I hinted into #82, I'd like to continue doing inline posting, as per the netiquette, but use org-msg to easily inject code and generated graphs into my messages.

These variables help me do that.

jeremy-compostella commented 3 years ago

Thanks for the patch. I will have a look at it in detail next week. I need to test it too.

On Fri, Jan 15, 2021, 1:53 PM Alexandre Duret-Lutz notifications@github.com wrote:

As I hinted into #82 https://github.com/jeremy-compostella/org-msg/issues/82, I'd like to continue doing inline posting, as per the netiquette, but use org-msg to easily inject code and generated graphs into my messages.

These variables help me do that.

You can view, comment on, or merge this pull request online at:

https://github.com/jeremy-compostella/org-msg/pull/84 Commit Summary

  • Add customization points to enable inline-posting

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jeremy-compostella/org-msg/pull/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMACBD2AG6O6NGTPODQRMLS2CTK3ANCNFSM4WES6FCQ .

jeremy-compostella commented 3 years ago

My bad I forgot to remove this second suggestion after I submitted the posting-style suggestions.

On Tue, Jan 19, 2021, 2:57 PM Alexandre Duret-Lutz notifications@github.com wrote:

@adl commented on this pull request.

In org-msg.el https://github.com/jeremy-compostella/org-msg/pull/84#discussion_r560523167 :

@@ -345,6 +345,44 @@ into multi-level quote blocks before being passed to the Org mode HTML export engine." :type '(boolean))

+(defcustom org-msg-send-original-with-reply t

org-msg-top-posting sounds ambiguous to me: you can still top-post even if you set both variable to nil: simply write above the quoted text. org-msg-include-original has my vote.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jeremy-compostella/org-msg/pull/84#discussion_r560523167, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMACBGGULJW7YRSFKMD57TS2X53TANCNFSM4WES6FCQ .

hpfr commented 3 years ago

The README for org-msg says it doesn't activate itself when replying to plain-text emails, so for mailing lists you'll already have inline posting working as expected. So is this PR intended to set up inline posting for HTML email? I'm kind of confused on how inline posting would work for HTML email in the first place. There is no predictability of text or lines appearing as expected, right? "Lines" aren't even really a thing, they're paragraphs, and there can be all kinds of images and stuff in the email as well.

Would you do this by taking the plain text part of a multipart email and using that for inline posting purposes?

Sorry if I'm misunderstanding, I don't really know much about how org-msg handles converting and manipulating the HTML citation.

adl commented 3 years ago

The README for org-msg says it doesn't activate itself when replying to plain-text emails, so for mailing lists you'll already have inline posting working as expected.

I planned to submit this as a separate issue: I sometime need to use HTML to reply to some plain-text emails. But I don't think its difficult to address.

So is this PR intended to set up inline posting for HTML email? I'm kind of confused on how inline posting would work for HTML email in the first place. There is no predictability of text or lines appearing as expected, right? "Lines" aren't even really a thing, they're paragraphs, and there can be all kinds of images and stuff in the email as well.

Yes. My mail-user-agent (in my case, gnus+w3m) already does the job of converting that HTML blob to a quoted plain text response I can edit before answering inline. By default I will reply in text/plain to any HTML email.

I just want to preserve that and be able to occasionally use org-mode (and more precisely org-babel) to format my response in HTML. In other word I want to keep the org-mode integration of org-msg (which I find supperior to org-mime), but I wan't org-msg to force me write outlook-like emails.

Would you do this by taking the plain text part of a multipart email and using that for inline posting purposes?

I'm sometimes doing that when the HTML is too messed up. But this is transparent to org-msg, as org-msg already works from the buffer that has been prepared by the underlying mail agent.

jeremy-compostella commented 3 years ago

Hi @adl,

I realized that I was probably too ambitious. I have been adding features and reworking a couple of things recently and I made a patch which should accommodate your needs on the experimental branch. Could you give it a shot ?

Thanks, Jeremy

jeremy-compostella commented 3 years ago

A minimal implementation which satisfy your original need is available on the master branch. Let's close this ticket. If it turns out I missed something, feel free to re-open.