Closed waywardmonkeys closed 8 months ago
Regarding the warnings on the noexcept
s, I used the same exception specification as std::optional and the move constructor/assignment operator are really only noexcept if T is nothrow move constructible. The move assignment could be relaxed to not require std::is_nothrow_move_assignable<T>::value
, or alternatively maybe it should be implemented to actually use an assignment operator. But that wouldn't resolve the clang-tidy warning of course.
Does clang-tidy give any information about what T
is leading to a false noexcept here? Or is it just waning that it could be false?
This is (perhaps) mainly for discussion as I saw you removed
clang-tidy
checks last year. These fix a variety of minor things.With one of the options that I was using, these still remain: