search

jeremy379 / laravel-openid-connect

Implement OpenID Connect inside Laravel
MIT License
25 stars 11 forks source link

Require lcobucci/jwt at least 4.3 and allow 5 #1

Closed coffe4u closed 1 year ago

coffe4u commented 1 year ago

This pull request updates the requirement for lcobucci/jwt from ^4.0 to ^4.3|^5.0. I used ^4.3 because the documentation says, "We're adding a few deprecation annotations on the version v4.3.0. So, before going to v5.0.0 please update to the latest 4.3.x version using composer:" I read through the upgrade guide and didn't find anything that needs to change for things to work with 5.x. Additionally, chose these values because laravel/passport uses them and because league/oauth2-server basically uses them.

jeremy379 commented 1 year ago

Thanks ;)

coffe4u commented 1 year ago

No problem @jeremy379. Thank you for putting this package together! I'm starting to use this package for a project and if all goes well, probably for all my projects. What is the best way to discuss updates? GitHub Issues?

jeremy379 commented 1 year ago

Here is fine for sure (Or any channel you prefer, I saw you followed me on Twitter too)