search

jeremy379 / laravel-openid-connect

Implement OpenID Connect inside Laravel
MIT License
25 stars 11 forks source link

Improved OIDC Discovery #15

Closed christiaangoossens closed 4 months ago

christiaangoossens commented 4 months ago

Improved the discovery document to be correct.

We only support code and token for grant_types_supported, as this library only supports Auth Code Flow by default and does not add the Implicit Flow and Hybrid Flow grant types (https://openid.net/specs/openid-connect-core-1_0.html#Authentication)

Sorry for the second PR so soon, did not expect you to create a release so fast ;) Luckily this one can be a patch to 2.2.1 as everything is optional and there is no backwards incompatibility. Default behaviour for scopes is the same.

christiaangoossens commented 4 months ago

Actually seeing https://github.com/jeremy379/laravel-openid-connect/issues/6, should we enable the other grant types automatically when you enable Implicit Grant using the same code as you listed in that issue? After that we can re-add them to discovery.

christiaangoossens commented 4 months ago

Okay, not proud of how many commits that took and sorry for the spam, but I am done with this PR. Hopefully it is a bit more spec compliant now, helping everyone! Thank you in advance for your time checking this.

jeremy379 commented 4 months ago

Hey Thanks a lot for this PR Looks good to me