search

jeremy379 / laravel-openid-connect

Implement OpenID Connect inside Laravel
MIT License
26 stars 13 forks source link

Add scope filter to getClaims() #27

Closed alecpl closed 2 months ago

alecpl commented 2 months ago

Fixes #22.

coffe4u commented 1 month ago

This introduces a breaking change. Anyone who implements the IdentityEntityInterface or Claimable interface will need to update the getClaims() method. This broke on production instances for us today.

jeremy379 commented 1 month ago

I'll revert and introduce that change in a new version

jeremy379 commented 1 month ago

After more check, I already used a 2.4.0 version (upgrading from 2.3.3)

You can force the version 2.3.*

I've also documented the breaking change.

coffe4u commented 1 month ago

I guess I was expecting Semantic Versioning. Increasing the middle number usually indicates new features. Breaking changes usually increases the first number. Not that big of a deal. I was able to fix it in my implementation in just a couple of minutes. Thanks for documenting it!