⬆️ bun 1.1.20 - Githubissues

jeremybanka commented 1 month ago

PR Type

enhancement, dependencies

Description

Updated oven-sh/setup-bun GitHub Action to version v2.0.1 across multiple workflow files.
Upgraded bun version from 1.1.18 to 1.1.20 in .github/workflows/coverage.yml, .github/workflows/integration.yml, .github/workflows/release.yml, and .github/workflows/semver.yml.
Updated bun version from 1.1.18 to 1.1.20 in the engines field of package.json.

Changes walkthrough 📝

Relevant files

Dependencies

coverage.yml `Upgrade Bun and GitHub Action in coverage workflow` .github/workflows/coverage.yml Updated `oven-sh/setup-bun` action to version `v2.0.1` Upgraded `bun` version from `1.1.18` to `1.1.20`	+2/-2
integration.yml `Upgrade Bun and GitHub Action in integration workflow` .github/workflows/integration.yml Updated `oven-sh/setup-bun` action to version `v2.0.1` Upgraded `bun` version from `1.1.18` to `1.1.20`	+4/-4
release.yml `Upgrade Bun and GitHub Action in release workflow` .github/workflows/release.yml Updated `oven-sh/setup-bun` action to version `v2.0.1` Upgraded `bun` version from `1.1.18` to `1.1.20`	+2/-2
semver.yml `Upgrade Bun and GitHub Action in semver workflow` .github/workflows/semver.yml Updated `oven-sh/setup-bun` action to version `v2.0.1` Upgraded `bun` version from `1.1.18` to `1.1.20`	+2/-2
package.json `Upgrade Bun version in package.json` package.json - Updated `bun` version from `1.1.18` to `1.1.20` in `engines` field	+1/-1

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
atom-io-fyi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2024 6:56am
wayfarer-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2024 6:56am

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: f40302d1aa9b46fe4f50d38d99be5d882ca109e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

github-actions[bot] commented 1 month ago

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Use environment variables to manage the Bun version across workflow files ___ Consider using a variable for the Bun version to ensure consistency across different workflow files. This can help in maintaining the version number in a single place, making future updates easier and less error-prone. [.github/workflows/coverage.yml [57-59]](https://github.com/jeremybanka/wayforge/pull/2261/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6R57-R59) ```diff -uses: oven-sh/setup-bun@v2.0.1 -bun-version: 1.1.20 +uses: oven-sh/setup-bun@${{ env.BUN_VERSION }} +bun-version: ${{ env.BUN_VERSION }} ``` Suggestion importance[1-10]: 9 Why: Using environment variables for the Bun version improves maintainability by centralizing version management, reducing the risk of inconsistencies across multiple files.	9
Best practice	Use a global environment variable for the Bun version to simplify updates ___ To avoid hardcoding the version number in multiple places, consider using a global environment variable defined at the workflow or repository level. [.github/workflows/release.yml [42-44]](https://github.com/jeremybanka/wayforge/pull/2261/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R42-R44) ```diff -uses: oven-sh/setup-bun@v2.0.1 -bun-version: 1.1.20 +uses: oven-sh/setup-bun@${{ env.BUN_VERSION }} +bun-version: ${{ env.BUN_VERSION }} ``` Suggestion importance[1-10]: 9 Why: Using a global environment variable for the Bun version enhances maintainability and simplifies future updates by centralizing version control.	9

coveralls commented 1 month ago

coverage: 91.614%. remained the same when pulling f40302d1aa9b46fe4f50d38d99be5d882ca109e5 on upgrade-bun/1.1.20 into 19cb19b6f58f1961941d91dc48c879b51291af65 on main.

jeremybanka / wayforge