search

jeremybarbet / react-native-portalize

The simplest way to render anything on top of the rest.
MIT License
335 stars 22 forks source link

Error: getRandomValues() not supported #10

Closed edc123 closed 4 years ago

edc123 commented 4 years ago

Affects 1.0.6 - upon launching app, I see the following error:

Screen Shot 2020-08-18 at 12 54 24 am

In my use case, I have some screens where I have two instances of Modalize - in other screens just one.

This issue can be fixed by the developer by following the steps at: https://github.com/uuidjs/uuid#getrandomvalues-not-supported as a polyfill is required for uuid to work in RN

Related to the fix in #9, which was a PR originally created to fix #7

harveyappleton commented 4 years ago

@jeremybarbet sad times, this is arising from the UUID implementation - as @edc123 rightly pointed out, we can also include this polyfill and all our problems go away.. only downside is adding this additional dependency, and it also requires cocoa pods on iOS. Whats your thoughts? Happy to do another PR with it included if you think thats best route :-)

jeremybarbet commented 4 years ago

Fix released in 1.0.7