search

jeremyckahn / chitchatter

Secure peer-to-peer chat that is serverless, decentralized, and ephemeral
https://chitchatter.im/
GNU General Public License v2.0
1.56k stars 205 forks source link

Show controls -> mute on share screen doesn't mute screen share #118

Open dillfrescott opened 1 year ago

dillfrescott commented 1 year ago

Some audio still slips through it seems. I think thats a bug right?

jeremyckahn commented 1 year ago

Thanks for reporting this @dillfrescott! I'm not totally clear on what the issue is. Are you saying that your computer's audio is being shared to peers when you are sharing your screen?

dillfrescott commented 1 year ago

Oh sorry, let me try to explain better. When one person screen shares with desktop audio, the other person can right click on the stream, select show controls and adjust the volume of the screen share. But even with the volume all the way down, it appears that half of the audio (?) appears to be routed through the mic input of the person too I think?

dillfrescott commented 1 year ago

Basically, the volume slider for the share screen only seems to lower the volume by about half instead of muting it when the slider is all the way on mute

jeremyckahn commented 1 year ago

Oh that's weird. The slider for volume control in the sidebar (#77) only affects peers' mic audio. Screenshare audio isn't managed at all by Chitchatter (I didn't even know that audio went through the screenshare). So it seems that there are two separate audio streams coming from a single peer: One for the mic and another for the screenshare. At the moment, using both audio streams may not result in a very good experience in Chitchatter, as there's no logic to specifically handle that right now.

I'd appreciate some dev help on this issue in case anyone would like to pitch in! 🙏