search

jeremyckahn / chitchatter

Secure peer-to-peer chat that is serverless, decentralized, and ephemeral
https://chitchatter.im/
GNU General Public License v2.0
1.4k stars 163 forks source link

Bug: I'm having issues with videos rendering in chat #311

Closed dillfrescott closed 1 month ago

dillfrescott commented 1 month ago

Images work fine, but videos tend to either spin forever or the play is grayed out and either way the thumbnail or video doesnt show up, just the box with the play pause and stuff.

jeremyckahn commented 1 month ago

Thanks for reporting this @dillfrescott. I am able to reproduce with a relatively small Big Buck Bunny test video: https://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4.

This seems to be an issue somewhere upstream in the libraries that Chitchatter is using to implement video embeds (https://github.com/webtorrent/webtorrent/issues/1887). I don't have time to properly diagnose and fix this issue, so I'm going to look to disable it for now.

dillfrescott commented 1 month ago

Gotcha! Okay

jeremyckahn commented 1 month ago

This is addressed in https://github.com/jeremyckahn/chitchatter/commit/56dbbf2665424920fe46eb528b82ed50c7f7c77b. With this change, inline media rendering will abort and print an error message if the file extension is unsupported. This is a quick fix and it's not as graceful as I'd like, but it should at least avoid users dealing with an obviously-broken experience.

Thanks for reporting this @dillfrescott!

brentonv commented 1 month ago

Wow videostream "only mp4 files are supported" and "mp4 files with certain audio codecs not playing" and last commit "Nov 12, 2020"

dillfrescott commented 1 month ago

Oh damn. Yeah looks like a better solution is in order.

jeremyckahn commented 1 month ago

Yeah... some of the libraries that Chitchatter depends on are a little old and creaky. They generally work well enough, but there are some rough edges like this. I don't know of any modern, maintained alternatives. :confused: