jeremyckahn / farmhand

A resource management game that puts a farm in your hand
https://www.farmhand.life
GNU General Public License v2.0
95 stars 23 forks source link

Add buy/sell events to Farmer's Log #478

Open tim-phillips opened 5 months ago

tim-phillips commented 5 months ago

I found that I wanted to reference past buys and sales when strategizing my purchases.

tim-phillips commented 5 months ago

I'm going to keep playing to see if the Crop Price Guide solves this.

jeremyckahn commented 5 months ago

I think this is a great idea! I've added it to the backlog. 🙂

jeremyckahn commented 5 months ago

I'm going to keep playing to see if the Crop Price Guide solves this.

It won't. The Crop Price Guide is an indicator near each item's price that shows whether it is a good or a bad buy:

Crop Price Guide screenshot

jeremyckahn commented 5 months ago

Actually it looks like this functionality is already implemented:

Farmer's log screenshot

I must have added it so long ago that I forgot. 😅

@tim-phillips Are you not seeing price events like this in your Farmer's Log?

tim-phillips commented 5 months ago

I am seeing those, but I was thinking of adding events such as "You purchased 20 carrot seeds at $8.32 each" or "You sold 8 Grade A Rainbow Milks at $60 each".

jeremyckahn commented 5 months ago

I am seeing those, but I was thinking of adding events such as "You purchased 20 carrot seeds at $8.32 each" or "You sold 8 Grade A Rainbow Milks at $60 each".

I see. That could be a useful addition! If we do this, it would be worth merging redundant notifications because a lot of players tend to just spam the "sell" and "buy" buttons rather than doing bulk operations. There's no prior art for that sort of thing in the codebase currently.

I don't think I'll be getting to this in the near future, but I'd be happy to support a PR to get it done!

tim-phillips commented 5 months ago

Ah, I hadn't considered spamming, that might make things a bit complicated. Maybe the events could be batched by day for each type of item.

jeremyckahn commented 5 months ago

Maybe the events could be batched by day for each type of item.

I think that would be a good way to handle it!