jeremyckahn / farmhand

A resource management game that puts a farm in your hand
https://www.farmhand.life
GNU General Public License v2.0
100 stars 25 forks source link

Make spacer display responsive in the menu #522

Open lillastormen opened 1 week ago

lillastormen commented 1 week ago

I noticed that there is a spacer in the menu, which creates scroll bar when it's not needed for certain window heights. The spacer is likely there to prevent navigation buttons to cover the content of the menu on smaller screens. I'd want to suggest hiding the spacer for the menu for screens wider than 1k pixels.

jeremyckahn commented 1 week ago

Hi @lillastormen, I think I know what you're talking about, but would you mind posting some screenshots to make sure we're talking about the same thing?

lillastormen commented 1 week ago

Hi @jeremyckahn,

here's the spacer in question: Screenshot 2024-10-08 at 23 20 15

As you can see it creates a scroll bar when it's not needed. My idea was that maybe hiding it, when it's not needed, could create a bit cleaner interface :)

And here's the screenshot, where the spacer is removed:

Screenshot 2024-10-08 at 23 30 03

jeremyckahn commented 1 week ago

Got it! Thanks for clarifying, @lillastormen. As you deduced, that spacer is there to make sure that the navigation buttons at the bottom don't obscure any content on mobile devices:

Screenshot of Farmhand on a small screen

I agree that it would be worth hiding the spacer on larger screens where it's not necessary. Good thinking @lillastormen! Feel free to open a PR. 🙂