jeremyckahn / shifty

The fastest TypeScript animation engine on the web
https://jeremyckahn.github.io/shifty/doc/
MIT License
1.54k stars 87 forks source link

Add support for RGBA color values #137

Closed jeremyckahn closed 3 years ago

jeremyckahn commented 3 years ago

This PR addresses #136 by adding support for rgba color strings. This was mostly already working before, as the token plugin supports arbitrary strings. However, the mid-tween rendered rgba strings would have decimal values as the r, g, and b values. This doesn't seem to be a problem for modern browsers, but it's also not quite correct. It seems safest to stick to the expectation of having r, g, and b be integer values, which is what this PR does.

/cc @hoomanaskari