fix: typescript promise type

jeremyckahn / shifty

The fastest TypeScript animation engine on the web

https://jeremyckahn.github.io/shifty/doc/

MIT License

1.54k stars 88 forks source link

fix: typescript promise type #160

Closed jspears closed 2 years ago

jspears commented 2 years ago

The current tweenable interface is not satisfying typescript definition of a promise. This is a slight annoyance when using the await for a tweenable, as typescript complains it is not a promise. This PR finishes the promise implementation, adds the interface in typescript, and adds a test for good measure.

jeremyckahn commented 2 years ago

Awesome! Thank you for the PR @jspears. I’m pretty busy this week, so I may not have time to review this until the weekend. I will follow up here when I can!

jeremyckahn commented 2 years ago

This has been released in 2.19.1!