search

jeremyckahn / shifty

The fastest TypeScript animation engine on the web
https://jeremyckahn.github.io/shifty/doc/
MIT License
1.54k stars 88 forks source link

`step()` should be called with the end value as well #18

Closed millermedeiros closed 12 years ago

millermedeiros commented 12 years ago

if you have a tween like:

var foo = new Tweenable();
foo.tween({
  from : { a : 1},
  to : { a : 10 },
  duration : 500,
  step : function() {
     console.log( foo.get() );
  }
});

the step callback never gets called with the value 10 (end value) and I think it should since in many cases the user may not want to set a callback for complete as well (if you are handling the changes based only on step).

millermedeiros commented 12 years ago

it was merged on 81e6257