named function expressions and IE < 9

jeremyckahn / shifty

The fastest TypeScript animation engine on the web

https://jeremyckahn.github.io/shifty/doc/

MIT License

1.54k stars 88 forks source link

named function expressions and IE < 9 #20

Closed millermedeiros closed 12 years ago

millermedeiros commented 12 years ago

JScript have some issues with named function expressions (memory leaks + generates 2 distinct functions) I would probably remove the names since they cause more problems than it solves...

PS: closure compiler already remove the names if they aren't being used anywhere, so no big deal, just a heads up..

jeremyckahn commented 12 years ago

Weird, I didn't know about that issue in IE. I'll take some time to clean up the code when I have a moment. Thanks!

millermedeiros commented 12 years ago

I guess we can ignore this, closure compiler will remove the name from the function expressions (since we are not calling them by the name), closing it for now.

jeremyckahn commented 12 years ago

The source should reflect best practices. Reopening. :)