search

jeremyckahn / shifty

The fastest TypeScript animation engine on the web
https://jeremyckahn.github.io/shifty/doc/
MIT License
1.54k stars 88 forks source link

Provide a way to manually define the "scheduling" policy #40

Closed jraoult closed 10 years ago

jraoult commented 10 years ago

I don't know if I was supposed to grunt build after those changes so I preferred not to push the dist directory and let you decide when to do it.

jeremyckahn commented 10 years ago

Thanks for making this Pull Request, @jraoult. Overall it looks solid, there are just a few things that need to be done before this can be merged:

  1. As-is, this Pull Request will not merge cleanly. There have been a number of changes to Shifty since you forked it. There's nothing that should break your patch, but please merge my master branch into your feature branch and resolve the conflicts.
  2. Please rev the version number in package.json and bower.json. Since this is adding an API, rev the minor version — this will be the 1.2.0 release.
  3. After updating the JSON files from step two, run grunt build. For Shifty, updating the binaries and documentation in dist/ are part of a version release.
jeremyckahn commented 10 years ago

Also, please add yourself as a contributor/author in the package.json/bower.json files.

jraoult commented 10 years ago

Ok, I'll do that (my AEST) tonight.

jraoult commented 10 years ago

Done

jeremyckahn commented 10 years ago

Thanks for making these changes! This looks great, I think Shifty will benefit from this new API. I will prepare a new release shortly.