Closed SBoudrias closed 9 years ago
Good call, I'll get to this soon!
Actually, this is not so easy to handle user side - even more in the setup we have on Yelp where we coordinates multiples tween based off a single one. So yeah, having this by default inside shifty would be very helpful!
This should be pretty straightforward to do. I don't have time to implement and test this now, but hopefully in the next day or so. If you need this sooner, feel free to make a Pull Request.
Okay, now I actually referenced the correct issue. Please test this out when you can and let me know if it's working for you.
@SBoudrias, did you get a chance to test out this fix?
Not yet, we have a bad infrastructure for open source third parties, so it's pretty involving. I should have some time to check it out next week.
Hey @jeremyckahn, sorry this took so long! Finally got around to test it on Yelp and the fix is resolving the issue described here.
No problem. I've merged the fix into master
, and it is available as version 1.3.11. Thanks for your help!
When seeking through a tweenable, I think it would make sense to not triggers the step handlers if there's no change at the time head.
For example:
This is easily handled by user side code, but handling this on the side of shifty would make user code cleaner and probably helps to silently improve performances.