Closed SBoudrias closed 9 years ago
Thanks for the Pull Request! the issue you described certainly sounds strange, but this fix looks pretty safe. Just one thing — could you change the PR to target the develop
branch instead of master
? I'm now using that branch to stage changes for stable release into master
.
Sure thing, here we go!
As this method always
schedule
another pass on the next animation frame, it happens that some time pass (in laggy browser or at load time) and the time difference would led shifty to believe the animation is over when we actually paused the tween before it ends.I had some issue tracking this bug down as it was flakey depending on how much the browser would block the main process.
Basically, this bug would appear when using
seek
at load time or on a low end device (laggy browser). The check for timeoutHandler_isEnded would just bump the animation to its end state.I'm not sure how we would unit test this bug as it's a pretty edge case behavior...