search

jeremyckahn / shifty

The fastest TypeScript animation engine on the web
https://jeremyckahn.github.io/shifty/doc/
MIT License
1.54k stars 88 forks source link

1.4 breaking seek #77

Closed SBoudrias closed 9 years ago

SBoudrias commented 9 years ago

Looks like the 1.4 release is breaking seek. Not sure what changed, and I haven't investigated the issue yet.

jeremyckahn commented 9 years ago

Yikes! Sorry about that. The unit tests are still passing, so that's a little surprising. Do you have a test case that reproduces the issue?

jeremyckahn commented 9 years ago

If you don't have one, don't worry about it — I should have some time tomorrow to get to the bottom of this.

SBoudrias commented 9 years ago

I don't have a reduced test case, but I can point you where the bug is.

It's these lines, since the code changed to do a check on the timestamp, the value of normalizedPosition is always 0 when it's triggered from a seek call.

jeremyckahn commented 9 years ago

Got it. It must be something to do with the recent "delay" functionality. I'll bet this can be demonstrated with a unit test that utilizes both the delay functionality as well as seek.

jeremyckahn commented 9 years ago

I just pushed and released a fix(1.4.2). Careless mistake on my part. Sorry about that. Thanks for reporting!