[minor] Allow promise implementation to be configured.

jeremyckahn / shifty

The fastest TypeScript animation engine on the web

https://jeremyckahn.github.io/shifty/doc/

MIT License

1.54k stars 88 forks source link

[minor] Allow promise implementation to be configured. #94

Closed 3rd-Eden closed 7 years ago

3rd-Eden commented 7 years ago

This pull request introduces a new option, promise to the configuration chain. This option allows developers to:

Manually provide a polyfill for Promise if the environment doesn't support it.
Use third party promise libraries for debugging purposes for example bluebird supports long stack traces to aid debugging.
Use libraries that introduce non-ES6 features like cancelable promises.

jeremyckahn commented 7 years ago

This looks great! Thanks for the PR. All I'd ask is that you add something for the new promise option to setConfig's JSDoc block. Once that's in, this will be ready to merge and release (which I should have time for later today).

jeremyckahn commented 7 years ago

Also, I changed the base of this PR to develop, per CONTRIBUTING.md.

3rd-Eden commented 7 years ago

Apologies for that, I thought I pointed it to the develop branch. I have updated the JSDoc block to include the promise option.

jeremyckahn commented 7 years ago

Thanks for making the change @3rd-Eden! This PR has been released in v2.0.4 😀