search

jeremycollake / x-wrt

Automatically exported from code.google.com/p/x-wrt
2 stars 0 forks source link

Selectable config language code parser in webif-page #141

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I tried changing the language in the latest X-WRT trunk and it didn't 
work. When I straced the webif-page binary I saw that it tried to open "/
usr/lib/webif/lang/ /common.txt" which means that the configuration 
parsing didn't work. I attached a patch which replaces the configuration 
parsing with a series of calls to libuci.

Original issue reported on code.google.com by der...@gmail.com on 6 May 2009 at 12:40

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you for your work.

The lang code parser in webif-page was fixed in
http://code.google.com/p/x-wrt/source/detail?r=4749. (See
http://forum.x-wrt.org/index.php/topic,1254.msg5582.html.)

My opinion is that the original parser could be faster (no benchmarks, just due 
to
the code size) and it should be preserved for smaller and UCI-less 
configurations.
I reclassified this issue to an enhancement therefore.

Would you be so kind and modify the patch to provide the logic to build 
webif-page
with or without linking to libuci?

Original comment by lubekgc@gmail.com on 26 May 2009 at 12:23