jeremycollake / x-wrt

Automatically exported from code.google.com/p/x-wrt
3 stars 0 forks source link

improved WakeOnLan Page #56

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hi all,

attached you will find a patch (against r4044) changing the following: -
MAC addresses are now accepted as long as the separator is non alphanumeric
(eg. 00-00-00... or 00/00/00...) - if lan is on interface br-lan, its
broadcast address, retrieved via ifconfig, is used by wol, to improve
functionality - missing packages warning only pops up if wol & etherwake
are missing, or one of these is chosen and actually not installed - put wol
first in list, as ether-wake at the moment not available in packages

Questions: - what is the correct path of ether-wake?
(/usr/sbin/ether-wake)? - what are the names of the lan interface if not
broadcom?

Regards Bud 

03/04/08 05:28:45 changed by bud

    * attachment patch.txt added.

patch for network-wakeonlan.sh
03/04/08 05:31:54 changed by bud

    * attachment patch2.txt added.

patch for network-wakeonlan.sh
(in reply to: ↑ description ) 03/04/08 05:34:16 changed by bud ¶

sorry .. patch.txt contains an error, pülease use patch2.txt

regards bud
03/04/08 07:00:02 changed by bud

    * attachment patch3.txt added.

sorry .. now it should work (I'm new to versioning & patches)
(follow-up: ↓ 3 ) 03/05/08 17:14:07 changed by lubek ¶

Please review the guidelines (skip the White Russian support requirement)
and this information is also useful:
http://wiki.x-wrt.org/index.php/Programmer%27s_Guide_to_the_Webif.

Always use the latest SVN copy of a file.

You have changed etherwake back to a wrong ether-wake (see
http://forum.x-wrt.org/index.php/topic,698.msg3456.html#msg3456).

I would copy the page from White Russian (see
http://wiki.x-wrt.org/index.php/Image:Wrp_network-wakeonlan.png) but it is
not possible because wol uses diferent (Kamikaze specific) configuration
and the page should use it.

You can get information about a package from the package directly or check
the package source in the SVN:
https://dev.openwrt.org/browser/packages/net/wol (and similarly for etherwake).

Would you be so kind and spend more time on page changes?
(in reply to: ↑ 2 ) 03/09/08 09:21:52 changed by bud ¶

Replying to l[[BR] ubek]:

    Please review the guidelines (skip the White Russian support
requirement) and this information is also useful:
http://wiki.x-wrt.org/index.php/Programmer%27s_Guide_to_the_Webif.

I'll do

    Always use the latest SVN copy of a file.

isn't 4044 not the latest version in the SVN? I just doublechecked it
again,
svn://svn.berlios.de/xwrt/trunk/package/webif/files/www/cgi-bin/webif/network-wa
keonlan.sh

    You have changed etherwake back to a wrong ether-wake (see
http://forum.x-wrt.org/index.php/topic,698.msg3456.html#msg3456).

unfortunately the the packages infos do not include file lists. where can i
get this kind of information?

    I would copy the page from White Russian (see
http://wiki.x-wrt.org/index.php/Image:Wrp_network-wakeonlan.png) but it is
not possible because wol uses diferent (Kamikaze specific) configuration
and the page should use it.

what are the differences? I just found the init script, and I now wonder
what it is meant to do? Start machines at router start? Maybe I want to
port the page to kamikaze if it makes sense.

    Would you be so kind and spend more time on page changes?

no problem with that. what do you want me to do?

regards bud
03/10/08 14:42:03 changed by lubek ¶

Sorry I forgot to include the link to guidelines (skip the White Russian
support requirement): http://forum.x-wrt.org/index.php/topic,114.0.html.

You used the latest SVN release but you also reverted the etherwake changes.

The Makefile lists all installed files in the install section:
https://dev.openwrt.org/browser/packages/net/wol/Makefile. You can use the
bin/Packages.filelist in your local buildroot or download the package and
extract the content (use GNU tar to extract control and data archives).

The init script design is wrong. The system starts with the "boot" action
which is converted to start by rc.common. :( We can modify it (and send the
patch to OpenWrt?). It would suffice to add an empty boot() function or
move start() to wake() and create an empty start() function.

Check the White Russian page whether you could reuse some parts. It would
save some work for translators.

Original issue reported on code.google.com by kemen04@gmail.com on 9 Jul 2008 at 8:48

Attachments: