search

jeremycx / node-LDAP

LDAP binding for node.js
MIT License
221 stars 43 forks source link

Build fails on Node 12 #117

Open BryanHunt opened 5 years ago

BryanHunt commented 5 years ago

This code fails to build when using Node 12. I tried forking the code and doing a simple update on the nan version, but the build still fails.

jeremycx commented 5 years ago

I haven't updated to 12 yet myself, so any work/research is appreciated...

jjhoughton commented 4 years ago

You can try this if you like https://github.com/jjhoughton/napi-ldap it hasn't seen a great deal of widespread use yet.

jjhoughton commented 4 years ago

Would you consider taking my changes @jeremycx if i open a pr? It's kind a rewrite though using n-api and c instead of c++.

jjhoughton commented 4 years ago

fixed here https://github.com/jeremycx/node-LDAP/pull/120

celevra commented 3 weeks ago

it also fails on v18 ;-) tried jjhoughton's respository but same error. i can't find an other ldap client library for node.js any chances to get this to work again?

jjhoughton commented 3 weeks ago

For my repo https://github.com/jjhoughton/napi-ldap you can try install these two system packages openldap-devel cyrus-sasl-devel and then set this environment variable when running npm install USE_SYSTEM_LDAP=1 npm i, that'll make it link to the system libraries. If you're using arm you'll have problems getting it to build if you don't do that. it's hard to know why it didn't compile without a stack trace. I'm currently using my repo on node 20 so it should work on node 18 given i know it also works on node 12 and node 16.

I did also make this change to get this repo working on node12 although I suspect you'd have to do further work to get it working with node18.

https://github.com/jeremycx/node-LDAP/pull/120

i can't find an other ldap client library for node.js

There was this one which looked pretty good but it looks like it's been decommissioned which is a shame https://www.npmjs.com/package/ldapjs