search

jeremydaly / lambda-api

Lightweight web framework for your serverless applications
https://serverless-api.com
MIT License
1.42k stars 126 forks source link

Typescript types for `type` is incorrect, should be "this" #193

Closed adworacz closed 1 year ago

adworacz commented 3 years ago

https://github.com/jeremydaly/lambda-api/blob/fc93110a8b9766c93a953deea67d13b9637519d2/index.d.ts#L197

https://github.com/jeremydaly/lambda-api/blob/2224ddf383e49285e9246e34409a39fec1fa57b5/lib/response.js#L407-L413

The current Typescript types for Response.type are incorrect, which breaks the ability to chain. Should be this instead.

adworacz commented 3 years ago

Actually looks like this is fixed by https://github.com/jeremydaly/lambda-api/pull/181

Can we get this merged?