Cannot find module '@aws-sdk/client-s3'

jeremydaly / lambda-api

Lightweight web framework for your serverless applications

https://serverless-api.com

MIT License

1.42k stars 126 forks source link

Closed oieduardorabelo closed 1 year ago

oieduardorabelo commented 1 year ago

hey folks 👋 , after migrating to v1, when running unit tests with lambda-api I see:

  Cannot find module '@aws-sdk/client-s3' from 'node_modules/lambda-api/lib/s3-service.js'

These dependencies should be either peerDependencies or dependencies and not devDependencies?

oieduardorabelo commented 1 year ago

btw, I do use AWS SDK v3 in my application, with @aws-sdk/client-dynamodb, but no S3 client.

naorpeled commented 1 year ago

Hey @oieduardorabelo, good point, wanna make a PR for it?

I unfortunately won't be near a computer until Sunday probably

oieduardorabelo commented 1 year ago

Closing this issue, it was fixed in the main branch by these PRs: