jeremydaly / lambda-warmer

A module to optimize AWS Lambda function cold starts
MIT License
525 stars 55 forks source link

Lambda-Warmer for AWS-SDK V3 needed #48

Closed m-courtin closed 1 year ago

m-courtin commented 1 year ago

Dear Maintainers, Dear Supporters,

we are currently using the Lambda-Warmer and are now migrating towards node18 -> near support end of node14 + 16. Your code currently is using the AWS SDK V2 in the index.js thru line 78 let lambda = require('./lib/lambda-service') and this one is requiring the Lambda client const Lambda = require('aws-sdk/clients/lambda'). This is in fact a runtime dependency and AWS is mandating AWS-SDK V3 for lambdas running under node18. So the current lambda-warmer is no longer working in a node18-Lambda.

Do you have plans when to release a version of the Lambda-Warmer compatible with AWS SDK V3 ?

Thank you very much in advance for your reply and best regards,

Michael

naorpeled commented 1 year ago

Dear Maintainers, Dear Supporters,

we are currently using the Lambda-Warmer and are now migrating towards node18 -> near support end of node14 + 16. Your code currently is using the AWS SDK V2 in the index.js thru line 78 let lambda = require('./lib/lambda-service') and this one is requiring the Lambda client const Lambda = require('aws-sdk/clients/lambda'). This is in fact a runtime dependency and AWS is mandating AWS-SDK V3 for lambdas running under node18. So the current lambda-warmer is no longer working in a node18-Lambda.

Do you have plans when to release a version of the Lambda-Warmer compatible with AWS SDK V3 ?

Thank you very much in advance for your reply and best regards,

Michael

Hey Michael, thanks for opening this issue. I think I'll be able to release a version that includes this sometime this week.

m-courtin commented 1 year ago

Dear Naor,

thanks a lot for the quick response and directly starting to work on the new version already this week is really awesome.

Best Regards, Michael

m-courtin commented 1 year ago

Hello Naor,

thank you very much for completing the migration towards AWS-SDK V3 and having now the new Lambda-Warmer Version2 available.

Best Regards, Michael