Fan-out lambda missing `lastAccess` attribute

jeremydaly / lambda-warmer

A module to optimize AWS Lambda function cold starts

MIT License

525 stars 55 forks source link

Fan-out lambda missing `lastAccess` attribute #6

Closed jmhummel closed 5 years ago

jmhummel commented 5 years ago

The lastAccess attribute is only set on the child invocations, but not on the original parent, which leads to both lastAccessed and lastAccessedSeconds fields appearing null on warm lambdas

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 15

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 14:	0.0%
Covered Lines:	32
Relevant Lines:	32

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 15

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 14:	0.0%
Covered Lines:	32
Relevant Lines:	32

💛 - Coveralls

jmhummel commented 5 years ago

Screenshot from CloudWatch:

jmhummel commented 5 years ago

More recent screenshot after schedule has run for a while, showing that only lambdas with count > 1 contain the lastAccessed and lastAccessedSeconds fields in their log output:

jmhummel commented 5 years ago

@jeremydaly Could you review this PR when you get a chance?

jeremydaly commented 5 years ago

Yes, sorry for the delay. I'll look at it tonight. Thanks for submitting it.

jeremydaly commented 5 years ago

I've merged this in and will add it to the next version.