jeremydaly / serverless-cloudside-plugin

Serverless plugin for using cloudside resources during local development
47 stars 16 forks source link

Set environment object if undefined #1

Closed alexdebrie closed 5 years ago

alexdebrie commented 5 years ago

If I set environment variables on individual functions but didn't have any global environment variables, I'd get an error of Cannot set property 'IS_CLOUDSIDE' of undefined on this line as this.serverless.service.provider.environment was undefined.

This just adds a check to see if it's undefined and creates an empty object if not.

Repro serverless.yml:

service: cloudside

provider:
  name: aws
  runtime: nodejs8.10
  stage: dev
  region: us-east-1

functions:
  myFunction:
    handler: handler.handler
    environment:
      QUEUE: !Ref myQueue

resources:
  Resources:
    myQueue:
      Type: AWS::SQS::Queue
      Properties:
        QueueName: ${self:service}-${self:provider.stage}-myQueue

plugins:
  - serverless-cloudside-plugin
jeremydaly commented 5 years ago

Great catch. Thanks, @alexdebrie!