search

jeremydaly / serverless-mysql

A module for managing MySQL connections at SERVERLESS scale
MIT License
1.21k stars 83 forks source link

feat: add support for a connection string #140

Closed sromic closed 1 year ago

sromic commented 1 year ago

Adding support for a connection string option.

Related to the issue: #115

sromic commented 1 year ago

Hi @jeremydaly please review this PR and if you think this makes sense to be added to this awesome lib :)

sromic commented 1 year ago

LGTM, let's add a test to validate this though

@naorpeled tests are added :) Also did a little refactoring on config method as well as ts type def.

naorpeled commented 1 year ago

LGTM, let's add a test to validate this though

@naorpeled tests are added :) Also did a little refactoring on config method as well as ts type def.

Awesome, will talk to Jeremy and aim to merge this sometime throughout the weekend

sromic commented 1 year ago

@naorpeled any news on this?

naorpeled commented 1 year ago

@naorpeled any news on this?

Hey, sorry for the delay, was super swamped with stuff to do and forgot about this.

Will message Jeremy now 🙏

naorpeled commented 1 year ago

Hey @sromic, updating that I've sent a message to Jeremy 2 days ago. Will let you know when I have any updates 🙏

sromic commented 1 year ago

Hey @sromic, updating that I've sent a message to Jeremy 2 days ago. Will let you know when I have any updates 🙏

@naorpeled Much appreciated!