search

jeremydavidson / react-search-panel

MIT License
1 stars 2 forks source link

feature/bug - Rendered html wraps the input in a form tag #35

Open NickSchimek opened 2 years ago

NickSchimek commented 2 years ago

The way we're using react-search-panel is that we are embedding it in our form. However, this produces invalid html as form tags should not be contained within other form tags.

Is there a reason for wrapping the output in a form tag? Could there be an option added that removes the form tag from the rendered html?

jeremydavidson commented 2 years ago

I don't recall a good reason for there to be a form tag, it should be fine to change to a div or perhaps move attributes to the parent div. PS, I merged #34 and published the new onFocus handler as version 1.0.9.

NickSchimek commented 2 years ago

Ok great, Thank you!