search

jeremydouglass / panelcode

Other
1 stars 0 forks source link

Tall rowgroups and run-off (bottom) images #3

Open jeremydouglass opened 7 years ago

jeremydouglass commented 7 years ago

From Maite:

Also, some images are running off the page (is that the bug in the renderer?). For instance, 6(c4, 4r2,0) in 99 Ways output. Looks like this could by an accurate panelcode (I need to go through and find the page since I don’t have the thumbnails), but I’m not sure. Basically, I’m wondering if this is an error on my end or just a bug?

screen shot 2017-09-27 at 1 43 18 pm
jeremydouglass commented 7 years ago

My response:

This is actually two problems:

Inter-row doubling is currently not scaling correctly. Panelcode thinks you described a page with a row 1/3rd of the page high, four rows 4/3rds of the page high, and a row 1/3rd of the page high. That’s 6/3rds, or 2 pages high. It shouldn’t do that — it should give you a 1/3 row, 4 1/12 rows, and a 1/3rd row, adding up to 1 page high.

The height of image output is fixed, so instead of drawing a very tall graphic, it “runs off the page.” This will be fixed, but bear with them for now.

The easiest workaround solution is to not encode inter-row height relationships, so 1_4_2(1+c3) would work perfectly fine without distortion or running off the page — even if it doesn’t convey the correct scale of the central row. The correct encoding could be included in a comment # next to the work-around encoding.