search

jeremyevans / rodauth

Ruby's Most Advanced Authentication Framework
http://rodauth.jeremyevans.net
MIT License
1.7k stars 94 forks source link

Support multi-level inheritance #191

Closed janko closed 2 years ago

janko commented 2 years ago

I've initially suggested this in #151, where we instead ended up making minimal changes that allowed rodauth-rails to support multi-level inheritance. With the support of named auth classes (which rodauth-rails 1.0 will now generate by default), I wanted to make another attempt at supporting multi-level inheritance in Rodauth itself. I think it's a pretty convenient way to share common configuration, and I thought it would be nice for Rodauth to provide this convenience out-of-the-box.

The internal_request feature already implements this functionality, so here we're just moving that into the core. Unlike my original attempt, here I didn't change any attribute readers/writers/accessors, nor assigned instance variables directly on the Rodauth::Auth class.

jeremyevans commented 2 years ago

Thanks for the patch! I'm OK with adding this feature. Let me play around with this, I might be able to make changes to simplify the implementation slightly.

janko commented 2 years ago

Nice, thank you 🙏🏻