Add more specs for early rendering on internal requests

jeremyevans / rodauth

Ruby's Most Advanced Authentication Framework

http://rodauth.jeremyevans.net

MIT License

1.67k stars 95 forks source link

Add more specs for early rendering on internal requests #304

Closed janko closed 1 year ago

janko commented 1 year ago

After https://github.com/jeremyevans/rodauth/pull/303, I found more places that are early rendering, which weren't being covered by existing internal request specs (#before_login_attempt & #new_account in verify_account, #show_lockout_page in lockout). Everything seems to be working fine, due to #set_error_flash being called before view rendering, but hopefully it's fine to add specs to ensure it continues working 🙂

jeremyevans commented 1 year ago

I agree, it's good to have these to avoid future regressions. Thanks for the patch!