Closed igor-alexandrov closed 12 months ago
See https://github.com/jeremyevans/sequel/issues/1809 for some background on why there is no Gemfile 😉
I see... in this case maybe Contributing guide should be updated. By the way, before creating this PR, I checked that both Roda (https://github.com/jeremyevans/roda/blob/master/Gemfile) and Sequel (https://github.com/jeremyevans/sequel/blob/master/Gemfile) have Gemfile in the repo.
Oh, somehow I missed that, and was sure I didn't see Gemfiles in other repos, but I guess it was just this one 👍🏻 Sorry for the confusion.
No worries. Let's wait for Jeremy for the clarification.
Looking at the commit messages, the Roda Gemfile was only added for Travis. The Sequel commit doesn't mention Travis, but it was added only a few days prior, so that is likely to be the reason it was added. Travis hasn't been used for many years, so if we want consistency, I'd rather remove Gemfile from Roda and Sequel. Using a Gemfile for library development is still a bad idea because of the lockfile issue, IMO. I haven't seen anyone claim that the benefits of having a Gemfile outweigh the lockfile issue.
So you suggest using gem install --development rodauth
? Maybe this should be added to contributing?
I'll add that to the Dependencies
section of the README
.
Description
This pull request adds a Gemfile to the Rodauth project. By including a Gemfile, it becomes easier for users and contributors to manage and install the required dependencies when working locally with Rodauth.
Changes